🌱 apibinding, types: remove ancestor check #2060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
kind/api-change
|
/cc @sttts |
s-urbaniak
force-pushed
the
ancestor
branch
from
6a2f538 to
9fb617c
Compare
sttts
reviewed
Sep 23, 2022
sttts
reviewed
Sep 23, 2022
| or a child of some ancestor. If it is unset, the path | ||
| of the APIBinding is used. | ||
| e.g. root:org:ws. If it is unset, the path of the APIBinding | ||
| is used. |
There was a problem hiding this comment.
there was, this is the expected state.
|
Missing the changes for ClusterWorkspaceTypes. |
it seems there is nothing to be done here. |
stevekuznetsov
approved these changes
Sep 23, 2022
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This removes ancestor checks for API bindings.
Related issue(s)
Follow-up for #1739
Fixes #2059